Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VSCODE] The validation tab should allow opening the appropriate file if found #2630

Closed
nmetulev opened this issue Feb 16, 2022 · 4 comments
Closed

Comments

@nmetulev
Copy link
Member

Tell us about your feature idea

If the validation tab for manifest and service worker finds a manifest or a service worker, double clicking the manifest or service worker root should open the file in vscode. In projects with multiple sites, it's not clear which manifest or service worker the tool has identified.

Do you have an implementation or a solution in mind?

image

Clicking (or double clicking) the red area should open the file.

Have you considered any alternatives?

No

@ghost
Copy link

ghost commented Mar 3, 2022

This issue has been marked as "needs attention 👋" due to no activity for 15 days. Please triage the issue so the fix can be established.

@ghost
Copy link

ghost commented Mar 18, 2022

This issue has been marked as "needs attention 👋" due to no activity for 15 days. Please triage the issue so the fix can be established.

1 similar comment
@ghost
Copy link

ghost commented Apr 2, 2022

This issue has been marked as "needs attention 👋" due to no activity for 15 days. Please triage the issue so the fix can be established.

@nmetulev nmetulev moved this to Todo 📃 in PWABuilder Apr 22, 2022
@jgw96 jgw96 modified the milestone: PWA Studio1.0 May 3, 2022
@jgw96 jgw96 moved this from Todo 📃 to Done ✔️ in PWABuilder May 10, 2022
@jgw96
Copy link
Contributor

jgw96 commented May 10, 2022

This was added in 1.0 pwa-builder/pwa-studio@7ddc71d

@jgw96 jgw96 closed this as completed May 10, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done ✔️
Development

No branches or pull requests

3 participants