Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VSCODE] Manifest Generation 2.0 #2671

Closed
jgw96 opened this issue Mar 4, 2022 · 1 comment · Fixed by pwa-builder/pwa-studio#68
Closed

[VSCODE] Manifest Generation 2.0 #2671

jgw96 opened this issue Mar 4, 2022 · 1 comment · Fixed by pwa-builder/pwa-studio#68

Comments

@jgw96
Copy link
Contributor

jgw96 commented Mar 4, 2022

Tell us about your feature idea

Update Manifest generation to be more automatic.

This issue #2628 started making me think, maybe the way we are doing things now for manifest generation, where the user fills out a form that then generates the JSON for the Web Manifest, is actually making it more complicated than we need.

Do you have an implementation or a solution in mind?

After looking more at how Snippets work in VSCode, I think we could GREATLY simplify the manifest generation by using a Snippet instead of this form. The command would write the manifest.json file and then add the Snippet to the file. This would also solve the issue where there are too many PWABuidler defaults in the manifest that users have to change. Using the VSCode Snippets, the user will be able to fill this out in a guided way.

Have you considered any alternatives?

Updating the UX of the form, but Im still convinced this is actually making things more complicated than they need to be.

@ghost
Copy link

ghost commented Mar 19, 2022

This issue has been marked as "needs attention 👋" due to no activity for 15 days. Please triage the issue so the fix can be established.

@joshsach joshsach added the 2204 label Apr 4, 2022
@jgw96 jgw96 added the p0 label Apr 4, 2022
@jgw96 jgw96 moved this to In Progress 🚧 in PWABuilder Apr 20, 2022
@jgw96 jgw96 moved this from In Progress 🚧 to In Review 💭 in PWABuilder May 2, 2022
Repository owner moved this from In Review 💭 to Done ✔️ in PWABuilder May 4, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done ✔️
Development

Successfully merging a pull request may close this issue.

3 participants