Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VSCODE] Deleted manifest still shows up in validation panel #2839

Closed
1 task done
jgw96 opened this issue Apr 27, 2022 · 1 comment
Closed
1 task done

[VSCODE] Deleted manifest still shows up in validation panel #2839

jgw96 opened this issue Apr 27, 2022 · 1 comment

Comments

@jgw96
Copy link
Contributor

jgw96 commented Apr 27, 2022

What happened?

Created and then deleted my manifest, but the validation panel shows I still have one.

What do you expect to happen?

Manifest should not show in the validation panel if it has been deleted from the project.

What version of VS Code are you using?

VS Code Stable

Relevant log output

No response

Are you using the latest version of the VS Code extension?

  • I am using the latest version of the VS Code extension
@jgw96
Copy link
Contributor Author

jgw96 commented Apr 29, 2022

Fixed with pwa-builder/pwa-studio@af62c84 . The extension was looking for the manifest file in directories such as build, which after deleting your root manifest.json, until you do a new build, the file would still be there. This is incorrect behavior as the manifest in build would also be deleted next time dev runs a build.

@jgw96 jgw96 closed this as completed Apr 29, 2022
Repository owner moved this from Todo 📃 to Done ✔️ in PWABuilder Apr 29, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done ✔️
Development

No branches or pull requests

2 participants