-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No "pyfiglet.fonts" module found #95
Comments
The directory |
Yeah - I removed it so that we can build a package with all the fonts or just those that have a suitable license. You need to pick which by running It's possible that there's a better way to specify that directly with setuptools, but I haven't looked as this project already used the Makefile. |
This should be fixed with #108 |
The fix in #108 was definitely wrong. The whole point of the split was to separate cleanly licensed fonts from ones with a less clear license (so that Linux distros can just pick the clean fonts). People using this codebase must use the makefile to decide which set they build. Looks like 114 still respects that logic. |
Thanks for commenting @peterbrittain. Judging from the error it looks like it lay within the pkg_resources logic which was replaced in #114 so I think it should no longer be an issue. |
Revising what I wrote last night: I take it the issue would still be present in some form, since it requires a 'make' invocation.. I guess it might be worth having some logic to load from the other directories if they're there, if someone would like to try and implement a fix. |
It depends what you want to achieve. The distro builders will still want some way to ensure that they just pick up licensed fonts (while others possibly just want everything), so you still need some way to make two different packages. With the legal requirements, you can't create one package with everything. This isn't really what setup.py is designed to do. What's prompting the revisiting of this issue? |
It's that someone |
So, the question is what do you want to build by default and how do you propose to manage the two different builds.... It would be trivial to default builds to safe fonts by just renaming that directory to "fonts". |
Hopefully addressed by #122 |
I'm going to close this as assumed fixed by #122, please ping this thread if you hit it again and I'll reopen, or file another issue. |
I installed pyserial without the pip package manager. I could not get the SSL module to work on my Nvidia Jetson (ubuntu 14), so installing via pip was not an option. Instead, I cloned the repo and installed from the setup script.
This is not an issue when installing via pip on another computer (same python and pip versions).
Here are the commands I used:
When I checked out the most recent release tag, it solved the issue. (I deleted the previous version from site-packages)
The text was updated successfully, but these errors were encountered: