seek to the start of the file after checking for a zip header #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanor
force-pushed
the
get-nonzip-fonts
branch
from
9b77825 to
69dc29b
Compare
This was referenced Aug 11, 2023
Fixes font listing for non-zipped fonts
All zip fonts and some non-zip fonts fail to parse with this error:
e.g. for `ascii12`:
```
Traceback (most recent call last):
File "pyfiglet/__init__.py", line 349, in loadFont
width, letter = __char(data)
^^^^^^^^^^^^
File "pyfiglet/__init__.py", line 316, in __char
end = self.reEndMarker.search(line).group(1)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'group'
```
pwaller
force-pushed
the
get-nonzip-fonts
branch
from
69dc29b to
8f3dabe
Compare
|
I've taken the liberty of rebase & force push after #114 to see the tests pass in CI. |
|
Tests passed in CI. Nicely done, thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes font listing for non-zipped fonts.
pyfiglet -lwas returning an empty list in my testing.This shows up 3 regressions: