Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Add the ability to convert a DAG to an MAG #96

Merged
merged 28 commits into from
Sep 26, 2023
Merged

[ENH] Add the ability to convert a DAG to an MAG #96

merged 28 commits into from
Sep 26, 2023

Commits on Sep 8, 2023

  1. Added function signature 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    9221f64 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into aryan_dag_to_mag 

    Signed-off-by: Aryan Roy <50577809+aryan26roy@users.noreply.github.com>
    @aryan26roy
    aryan26roy committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    74b6612 View commit details
    Browse the repository at this point in the history

  3. fixed the return statement 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    03eb9cb View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2023

  1. Rebased onto main 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    65ff956 View commit details
    Browse the repository at this point in the history

  2. testing 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    1e42a20 View commit details
    Browse the repository at this point in the history

  3. Bump actions/checkout from 3 to 4 (py-why#94) 

    Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    @dependabot @aryan26roy
    dependabot[bot] authored and aryan26roy committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    2b84d74 View commit details
    Browse the repository at this point in the history

  4. Added function signature and rebased 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    f0f25d4 View commit details
    Browse the repository at this point in the history

  5. Resolved merge issue 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    f293c99 View commit details
    Browse the repository at this point in the history

  6. Wrote down the algorithm 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    5df8578 View commit details
    Browse the repository at this point in the history

  7. Added partial implementation 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    7fd8c93 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Added page number 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    e5f16bb View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Completed implementation 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    e247bd7 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Added some tests and improved the implementation 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    b8b69d2 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Added two working tests 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    f6656d4 View commit details
    Browse the repository at this point in the history

  2. Added another test 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    7832e88 View commit details
    Browse the repository at this point in the history

  3. Linting 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    302733a View commit details
    Browse the repository at this point in the history

  4. Changelog and linting 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    916743a View commit details
    Browse the repository at this point in the history

  5. Linting 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    4e9b7e5 View commit details
    Browse the repository at this point in the history

  6. implemented reccomendations on code readabiliy 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    f7eb0b8 View commit details
    Browse the repository at this point in the history

  7. Linting 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    7e30a76 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2023

  1. Update pywhy_graphs/algorithms/generic.py 

    Co-authored-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Aryan Roy <50577809+aryan26roy@users.noreply.github.com>
    @aryan26roy @adam2392
    aryan26roy and adam2392 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    4daf699 View commit details
    Browse the repository at this point in the history

  2. Update pywhy_graphs/algorithms/generic.py 

    Co-authored-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Aryan Roy <50577809+aryan26roy@users.noreply.github.com>
    @aryan26roy @adam2392
    aryan26roy and adam2392 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    822e355 View commit details
    Browse the repository at this point in the history

  3. Added adc check to each MAG 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    4657c72 View commit details
    Browse the repository at this point in the history

  4. Added tests for inducing path edge case 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    29ac9cf View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Added checks for maximality in tests 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    f8865e6 View commit details
    Browse the repository at this point in the history

  2. improved memoisation 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    58723ed View commit details
    Browse the repository at this point in the history

  3. Using frozenset 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    d5fb5b9 View commit details
    Browse the repository at this point in the history

  4. Added test for is_maximal 

    Signed-off-by: Aryan Roy <aryanroy5678@gmail.com>
    @aryan26roy
    aryan26roy committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    6cf1edf View commit details
    Browse the repository at this point in the history