Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyosmeta missing joss doi and sometimes parsing DOI values differently; we should add some checks for consistency #228

Open
lwasser opened this issue Nov 21, 2024 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@lwasser
Copy link
Member

lwasser commented Nov 21, 2024

In some issues, we have a line that is JOSS DOI, and in others, it is JOSS: . Because of this sometimes pyosmeta misses finding the JOSS DOI for a package. it would be good to make pyometra flexible enough to accept either as viable for the JOSS attribute in our model. This relates to this issue because, in many cases, our website isn't rendering doi information correctly.

A few other places where it's failing oddly

xclim it's returning true for some reason? I am not sure why as it looks similar to other packages in the review issue

I think the bigger picture here is that we need pyosmeta to do a few things when parsing both the archive field and the joss doi

  1. sometimes for archive, a user provides a link to a github release or tag. If that is the case we should return a new field called release_tag: that contains that url
  2. for joss - we need to ensure pyosmeta can handle both joss and joss doi when it parses our issues
  3. for zenodo - we need to make sure that
    • the user provides a badge
    • if they don't make one but provide a zenodo link, we can parse that url into a badge
    • if they provide the latest badge let's put it in another yaml element called latest_doi:
    • this will make the website parsing side of things easier.

We should also validate that there is a valid url provided within the badge.

@lwasser lwasser changed the title pyosmeta missing joss doi pyosmeta missing joss doi and sometimes parsing DOI values differently; we should add some checks for consistency Nov 21, 2024
@lwasser lwasser added the help wanted Extra attention is needed label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
Development

No branches or pull requests

1 participant