Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todo: allow user-control over slice-reduction mechanism #12

Open
tlambert03 opened this issue Jun 9, 2024 · 4 comments
Open

todo: allow user-control over slice-reduction mechanism #12

tlambert03 opened this issue Jun 9, 2024 · 4 comments

Comments

@tlambert03
Copy link
Member

double clicking on a slider label converts it to a slice slider:

Untitled.mov

currently, the hard-coded behavior is to reduce extra remaining dimensions via max().

self, data: np.ndarray, reductor: Callable[..., np.ndarray] = np.max

this should be configurable (on a per-axis basis?)

@alisterburt
Copy link

this should be configurable (on a per-axis basis?)

definitely, e.g. average over time and max/min projection of the resulting 3D makes total sense to me

how to support from the UI is a good question... context menu on the dims slider?

@tlambert03
Copy link
Member Author

i like that idea.
another thing that needs configurability is which axes are visualized. (rather than just a roll function). and wherever that is shown (which might be a popup on a right click of the 2d/3d button) could also contain the configuration for reduced dimensions. However, I think i prefer your proposal: having the reduction mechanism right next to the slice slider

vaguely related concept: it could be a neat feature for even the "visible" axes (x,y,z) to have sliders that would essentially just allow cropping. like this:

Screen.Recording.2024-06-14.at.9.01.27.PM.mov

normally, those sliders would be hidden (indicating you want the full extent of the visible axes), but some feature could show them.

@alisterburt
Copy link

are you visualising the last two/three dimensions by default?

My fav idea for specifying visualized dims would be something like this
image

@tlambert03
Copy link
Member Author

Oooo nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants