Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows logic for JAX in Nox and remove redundant Homebrew installations #3941

Closed
kratman opened this issue Mar 28, 2024 · 3 comments · Fixed by #4143
Closed

Update windows logic for JAX in Nox and remove redundant Homebrew installations #3941

kratman opened this issue Mar 28, 2024 · 3 comments · Fixed by #4143
Assignees
Labels
priority: medium To be resolved if time allows

Comments

@kratman
Copy link
Contributor

kratman commented Mar 28, 2024

Followup to comments from @agriyakhetarpal in #3932

Changing settings for the JAX build was outside the scope of the other ticket, so this one is my reminder to go fix the issues.

We can now remove the sys.platform != "win32" checks from everywhere in the file because all dependencies will now support all platforms

The only condition we will still need should be the Python <3.9 version check (where JAX is not available)

@kratman kratman self-assigned this Mar 28, 2024
@kratman
Copy link
Contributor Author

kratman commented Mar 29, 2024

I will also look into the DAE modulo test from #3932 that caused a tiny drop in coverage

@agriyakhetarpal
Copy link
Member

On another note, we shouldn't need to install two of the macOS system dependencies now with this, just graphviz and libomp should be required. We are fine with using Accelerate as a BLAS vendor and we needed gcc to get gfortran earlier for compiling scikits.odes (it wasn't being used for compiling IDAKLU anyway, we used the system Clang for that). I guess these changes would probably be better in a separate PR.

cross-posted from #3932 (comment)

@agriyakhetarpal agriyakhetarpal changed the title Update windows logic for JAX in Nox Update windows logic for JAX in Nox and remove redundant Homebrew installations Mar 29, 2024
@kratman kratman mentioned this issue Apr 1, 2024
5 tasks
@kratman
Copy link
Contributor Author

kratman commented Apr 2, 2024

All that should be left in this ticket is the modulo test. I will work on getting that sorted out this week

@agriyakhetarpal agriyakhetarpal added the priority: medium To be resolved if time allows label Apr 12, 2024
@kratman kratman mentioned this issue Jun 5, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium To be resolved if time allows
Projects
None yet
2 participants