We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
At the moment, I believe the Casadi solver modes are tested on a toy model:
PyBaMM/tests/unit/test_solvers/test_casadi_solver.py
Line 17 in 90c1c35
This issue is to add additional tests on an SPM or equivalent with assert for ensuring the results for each solver mode.
As we are moving towards the "safe with events" mode in PyBOP, it would be ideal to have the mode tested for across the pybamm models.
"safe with events"
No response
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Description
At the moment, I believe the Casadi solver modes are tested on a toy model:
PyBaMM/tests/unit/test_solvers/test_casadi_solver.py
Line 17 in 90c1c35
This issue is to add additional tests on an SPM or equivalent with assert for ensuring the results for each solver mode.
Motivation
As we are moving towards the
"safe with events"
mode in PyBOP, it would be ideal to have the mode tested for across the pybamm models.Possible Implementation
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: