From 095732916c6fa918611755548721707ee9d59b2c Mon Sep 17 00:00:00 2001 From: Valentin Sulzer Date: Tue, 19 Mar 2024 12:56:59 -0400 Subject: [PATCH 1/3] rename separator porosity to transport efficiency --- .../surface_potential_form/full_surface_form_conductivity.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pybamm/models/submodels/electrolyte_conductivity/surface_potential_form/full_surface_form_conductivity.py b/pybamm/models/submodels/electrolyte_conductivity/surface_potential_form/full_surface_form_conductivity.py index 83bcfb8027..d2f65b3f92 100644 --- a/pybamm/models/submodels/electrolyte_conductivity/surface_potential_form/full_surface_form_conductivity.py +++ b/pybamm/models/submodels/electrolyte_conductivity/surface_potential_form/full_surface_form_conductivity.py @@ -78,7 +78,7 @@ def get_coupled_variables(self, variables): else: phi_e_n = variables["Negative electrolyte potential [V]"] phi_e_n_s = pybamm.boundary_value(phi_e_n, "right") - tor_s = variables["Separator porosity"] + tor_s = variables["Separator transport efficiency"] T = variables["Separator temperature [K]"] chiRT_over_Fc_e_s = param.chiRT_over_Fc(c_e_s, T) From fd1bfb772ba9444c4a42b9d50f0038749a871343 Mon Sep 17 00:00:00 2001 From: Valentin Sulzer Date: Tue, 19 Mar 2024 12:57:59 -0400 Subject: [PATCH 2/3] changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1dec0c6741..65a75c1005 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ ## Bug Fixes +- Fixed bug where separator porosity was used in calculation instead of transport efficiency ([#3905](https://github.com/pybamm-team/PyBaMM/pull/3905)) - Initial voltage can now match upper or lower cut-offs exactly ([#3842](https://github.com/pybamm-team/PyBaMM/pull/3842)) - Fixed a bug where 1+1D and 2+1D models would not work with voltage or power controlled experiments([#3829](https://github.com/pybamm-team/PyBaMM/pull/3829)) - Update IDAKLU solver to fail gracefully when a variable is requested that was not in the solves `output_variables` list ([#3803](https://github.com/pybamm-team/PyBaMM/pull/3803)) From 3b6a2df6765e16af552bb1b8153a1504e1108161 Mon Sep 17 00:00:00 2001 From: Valentin Sulzer Date: Tue, 19 Mar 2024 13:13:46 -0400 Subject: [PATCH 3/3] fix typo --- .../surface_potential_form/full_surface_form_conductivity.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pybamm/models/submodels/electrolyte_conductivity/surface_potential_form/full_surface_form_conductivity.py b/pybamm/models/submodels/electrolyte_conductivity/surface_potential_form/full_surface_form_conductivity.py index d2f65b3f92..18470f9df8 100644 --- a/pybamm/models/submodels/electrolyte_conductivity/surface_potential_form/full_surface_form_conductivity.py +++ b/pybamm/models/submodels/electrolyte_conductivity/surface_potential_form/full_surface_form_conductivity.py @@ -78,7 +78,7 @@ def get_coupled_variables(self, variables): else: phi_e_n = variables["Negative electrolyte potential [V]"] phi_e_n_s = pybamm.boundary_value(phi_e_n, "right") - tor_s = variables["Separator transport efficiency"] + tor_s = variables["Separator electrolyte transport efficiency"] T = variables["Separator temperature [K]"] chiRT_over_Fc_e_s = param.chiRT_over_Fc(c_e_s, T)