From 7d17c90c4c093d2c765a0bc14949951008f6ef77 Mon Sep 17 00:00:00 2001 From: "Ralf W. Grosse-Kunstleve" Date: Thu, 18 May 2023 10:55:51 -0700 Subject: [PATCH] Remove `#include ` from absl_casters.h While working on https://github.com/pybind/pybind11/pull/4674 I came to realize that this include is not needed here. Note however that the pybind11/cast.h changes under https://github.com/pybind/pybind11/pull/4601 are still needed, therefore pybind11_abseil still requires current pybind11 master. PiperOrigin-RevId: 533182724 --- WORKSPACE | 9 +++++++++ pybind11_abseil/absl_casters.h | 1 - 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/WORKSPACE b/WORKSPACE index dd238bb..a7cb11b 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -33,6 +33,15 @@ http_archive( build_file = "@pybind11_bazel//:pybind11.BUILD", strip_prefix = "pybind11-master", urls = ["https://github.com/pybind/pybind11/archive/refs/heads/master.tar.gz"], + # For easy local testing with pybind11 releases: + # * Comment out the 2 lines above. + # * Uncomment and update the 3 lines below. + # * To compute the sha256 string: + # * Download the .tar.gz file (e.g. curl or wget). + # * sha256sum v2.10.4.tar.gz + # strip_prefix = "pybind11-2.10.4", + # sha256 = "832e2f309c57da9c1e6d4542dedd34b24e4192ecb4d62f6f4866a737454c9970", + # urls = ["https://github.com/pybind/pybind11/archive/refs/tags/v2.10.4.tar.gz"], ) load("@pybind11_bazel//:python_configure.bzl", "python_configure") diff --git a/pybind11_abseil/absl_casters.h b/pybind11_abseil/absl_casters.h index a224c3e..54e985a 100644 --- a/pybind11_abseil/absl_casters.h +++ b/pybind11_abseil/absl_casters.h @@ -33,7 +33,6 @@ #include #include #include -#include // Must NOT appear before at least one pybind11 include. #include // Python datetime builtin.