Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Synchronise PyBOP with PyBaMM@develop #312

Closed
BradyPlanden opened this issue May 5, 2024 · 0 comments · Fixed by #313
Closed

[Bug]: Synchronise PyBOP with PyBaMM@develop #312

BradyPlanden opened this issue May 5, 2024 · 0 comments · Fixed by #313
Assignees
Labels
bug Something isn't working

Comments

@BradyPlanden
Copy link
Member

Python Version

N/A

Describe the bug

PyBaMM's breaking changes ahead of their v24.5 release can be found here: https://github.com/pybamm-team/PyBaMM/blob/develop/CHANGELOG.md

Our most recent weekly test against their develop branch can be found here: https://github.com/pybop-team/PyBOP/actions/runs/8886663430/job/24400545873

This issue is to fix our codebase for these breaking changes.

Steps to reproduce the behaviour

pytest --unit and pytest --integration with pybamm@develop installed in virtualenv

Relevant log output

No response

@BradyPlanden BradyPlanden added the bug Something isn't working label May 5, 2024
@BradyPlanden BradyPlanden self-assigned this May 5, 2024
@BradyPlanden BradyPlanden linked a pull request May 5, 2024 that will close this issue
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant