Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename and merge LogPosterior and MAP class #459

Closed
BradyPlanden opened this issue Aug 13, 2024 · 0 comments · Fixed by #483
Closed

Rename and merge LogPosterior and MAP class #459

BradyPlanden opened this issue Aug 13, 2024 · 0 comments · Fixed by #483
Labels
enhancement New feature or request

Comments

@BradyPlanden
Copy link
Member

Feature description

This issue is a continuation of #340 where the class LogPosterior is introduced. This class can be combined with MAP with a final class name of LogPosterior. At the same time, the finite difference gradient computation can be made a fallback implementation if a prior is provided that does not have a gradient computation method.

Motivation

No response

Possible implementation

No response

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace pybop.MAP with pybop.LogPosterior pybop-team/PyBOP
1 participant
@BradyPlanden