-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR #709 breaks python 3.6.1 compatibility #745
Comments
Interesting -- what are you running on that has Python 3.6.1 out of curiosity? |
The two potential fixes are to drop NoReturn or drop support for < 3.6.2. I've been unable to find a Linux distribution under current support that ships 3.6.0/3.6.1, but I'm interested in your particular case. |
An internal build environment, via pyenv. |
To give more context, my specific path to this error was via paramiko, which will pull in the latest (> 1.0.1) pynacl version by default during installation. |
This is an issue with PyGithub (https://github.com/PyGithub/PyGithub) on 3.6.1. |
@yuvalshirav are you seeing a lot of 3.6.0/3.6.1 users? I'm inclined to just drop |
#709
src/nacl/bindings/crypto_generichash.py:14
from typing import NoReturn, TypeVar
NoReturn was introduced in python 3.6.2, on 3.6.1 fails with:
ImportError: cannot import name ‘NoReturn’
The text was updated successfully, but these errors were encountered: