-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numerous test failures with libressl #791
Comments
This is an attempt to get to the bottom of this issue with synapse. I managed to get Is there any chance of actually addressing these issues? The "certificate verify failed" is most pressing for me, but I'm sure some of these actually require fixes? |
Semi-related question: |
This is a custom ports build with LibreSSL of course. |
Thanks for the information! Over the years the paths of OpenSSL and LibreSSL have separated. Although LibreSSL initially started as a fork of OpenSSL 1.0.1g, it's no longer a drop-in replacement for OpenSSL. There several differences in API and even in behavior. It's become increasingly complicated and painful to write software that works with OpenSSL and LibreSSL. Several Linux distros (Alpine, Gentoo, Void) have given up and moved back to OpenSSL recently. It's unfortunate. IMHO the best course of action is to work with OpenSSL and LibreSSL upstream development on a common API. If you can get both projects (and maybe even BoringSSL) to reconcile their APIs, then projects like PyOpenSSL can support both more easily. |
I am very familiar with the background of this, including the ongoing efforts (some of which you mention) by many well-meaning developers to passively require using "one SSL stack to rule them all" if you want anything to actually work. I do not believe this is a healthy policy myself, but that's a debate for another time. So I provide this test result as non-zero incentive to try to be compatible with both LibreSSL and OpenSSL. That being said, I completely understand if you take no action and/or close this ticket. I would like it to be clearly understood that I do not wish to force any work on any other developer. :) If it helps any, the certificate verification part of the failing tests (my major issue) was a problem with the FreeBSD pkg system and not PyOpenSSL. |
I observe test failures when building against
libressl
(2.7.4).I don't know anything about this codebase, but looking briefly at the error for, say,
test_set_session_id_fail
, I think the test is expecting a certain specific error string, with libressl is not exactly providing, despite it appearing to fail in the correct way.Are these errors mistakes in the tests, or do you consider them to be mistakes in
libressl
?My full test output follows:
The text was updated successfully, but these errors were encountered: