Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with toast #282

Closed
sydney-runkle opened this issue Apr 23, 2024 · 5 comments · Fixed by #300
Closed

Issue with toast #282

sydney-runkle opened this issue Apr 23, 2024 · 5 comments · Fixed by #300
Labels
bug Something isn't working
Milestone

Comments

@sydney-runkle
Copy link
Member

sydney-runkle commented Apr 23, 2024

See demo for details, need to resolve before v0.6.0: https://fastui-demo.onrender.com/components#toast

@sydney-runkle sydney-runkle added this to the v0.6.0 milestone Apr 23, 2024
@ManiMozaffar
Copy link
Contributor

Might make sense to add some ui test with playwright to improve confidence on release?
I can take over that @sydney-runkle :) And CI pipeline.

@sydney-runkle
Copy link
Member Author

@ManiMozaffar,

Go for it!

@sydney-runkle
Copy link
Member Author

@ManiMozaffar,

I'm hoping to finish up the docs by the end of the week, then crank through some PRs and issues next week :).

@ManiMozaffar
Copy link
Contributor

Understood. Will do it over the weekend then! At Noah labs, we're using FastUI to write internal tool and it's been game changer for us, because development speed is just way faster.

Would be very nice if documentation comes with the limitation for the component. I haven't looked through the toast component yet, but that would awesome to have toast rendered from "form submission response".

@sydney-runkle
Copy link
Member Author

I believe @hramezani figured out that we just need to build the internal packages for this to work - should be resolved tomorrow!

@sydney-runkle sydney-runkle added the bug Something isn't working label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants