-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Computed fields don't work with TypedDict #657
Labels
enhancement
New feature or request
Comments
Might even make it a bit more performant too.. |
Yep! In any case, not an urgent issue since this is all new features. |
@adriangb given your example, what should |
I forget how we give it a function but ultimately there should be a function that gets called with the empty dict and comes up with a field value. |
4 tasks
1 task
sydney-runkle
added
enhancement
New feature or request
and removed
bug
Something isn't working
labels
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
They're in the schema but there are no tests and if you look at the source it's grabbing attributes, which won't work with TypedDict. We should do the same thing we do with model/field validators/serializer and hold a reference to the function before building the schema.
The text was updated successfully, but these errors were encountered: