Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build dummy objects when populating ObTypeLookup #1086

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Nov 21, 2023

Change Summary

Slight simplification that I noticed while working on #1085.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @samuelcolvin

@davidhewitt
Copy link
Contributor Author

please review

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #1086 (93ae215) into main (be9c21c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1086      +/-   ##
==========================================
- Coverage   89.62%   89.62%   -0.01%     
==========================================
  Files         106      106              
  Lines       16366    16363       -3     
  Branches       35       35              
==========================================
- Hits        14668    14665       -3     
  Misses       1691     1691              
  Partials        7        7              
Files Coverage Δ
src/serializers/ob_type.rs 81.02% <100.00%> (-0.23%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be9c21c...93ae215. Read the comment docs.

Copy link

codspeed-hq bot commented Nov 21, 2023

CodSpeed Performance Report

Merging #1086 will improve performances by 33.77%

Comparing dh/no-dummy-objects (93ae215) with main (be9c21c)

Summary

⚡ 2 improvements
✅ 138 untouched benchmarks

Benchmarks breakdown

Benchmark main dh/no-dummy-objects Change
test_core_str 37.9 µs 31.1 µs +22.06%
test_validate_literal[json-few_mixed] 37.2 µs 27.8 µs +33.77%

@davidhewitt davidhewitt merged commit 3d3f406 into main Nov 21, 2023
30 checks passed
@davidhewitt davidhewitt deleted the dh/no-dummy-objects branch November 21, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants