Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support newest jiter behaviour #1092

Merged
merged 2 commits into from
Nov 27, 2023
Merged

support newest jiter behaviour #1092

merged 2 commits into from
Nov 27, 2023

Conversation

samuelcolvin
Copy link
Member

  • use the newest jiter with support for string caching
  • use jiter's python_parse to parse python when there's no validator, this should make JSON validation for Any fields significantly faster

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #1092 (755ce61) into main (5b63e7a) will increase coverage by 0.06%.
The diff coverage is 86.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1092      +/-   ##
==========================================
+ Coverage   89.64%   89.70%   +0.06%     
==========================================
  Files         106      106              
  Lines       16363    16359       -4     
  Branches       35       35              
==========================================
+ Hits        14668    14675       +7     
+ Misses       1688     1677      -11     
  Partials        7        7              
Files Coverage Δ
src/input/input_abstract.rs 70.58% <ø> (ø)
src/input/input_json.rs 89.16% <ø> (+0.72%) ⬆️
src/input/input_python.rs 97.79% <ø> (-0.05%) ⬇️
src/input/input_string.rs 37.95% <ø> (+1.84%) ⬆️
src/input/shared.rs 97.16% <ø> (-0.23%) ⬇️
src/validators/mod.rs 95.15% <100.00%> (+0.06%) ⬆️
src/validators/json.rs 98.38% <96.77%> (-1.62%) ⬇️
src/lib.rs 87.14% <0.00%> (+1.22%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b63e7a...755ce61. Read the comment docs.

Copy link

codspeed-hq bot commented Nov 23, 2023

CodSpeed Performance Report

Merging #1092 will improve performances by 14.74%

Comparing new-jiter (755ce61) with main (5b63e7a)

Summary

⚡ 1 improvements
✅ 139 untouched benchmarks

Benchmarks breakdown

Benchmark main new-jiter Change
test_small_class_core_model 58.5 µs 51 µs +14.74%

@davidhewitt davidhewitt enabled auto-merge (squash) November 27, 2023 11:11
@davidhewitt davidhewitt merged commit c7daf16 into main Nov 27, 2023
29 checks passed
@davidhewitt davidhewitt deleted the new-jiter branch November 27, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants