use full type names in errors #1342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm ok with this, but this is potentially a breaking change for some folks, so let's wait until the next minor release (tomorrow or Wednesday probably), so that we can chat about this before merging. |
|
I'm guessing it would generally only break tests, but still... |
CodSpeed Performance ReportMerging #1342 will not alter performanceComparing Summary
|
4 tasks
|
Personally I'm 👎 for this, I think it'll be a significant breaking change for lots of people because of tests, I also think it's a bit uglier for little gain. |
|
Closing for now, given the above comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Supersedes #1276, using a new PyO3 0.22 API to get the full type name.
Related issue number
Closes pydantic/pydantic#7911
Checklist
pydantic-core(except for expected changes)