tidy up some uses of Bound<'_, PyString>::to_str
#1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1544 will not alter performanceComparing Summary
|
davidhewitt
commented
Nov 19, 2024
Comment on lines
-612
to
-615
| ObType::Str | ObType::StrSubclass => { | ||
| let py_str = key.downcast::<PyString>()?; | ||
| Ok(Cow::Owned(py_str.to_str()?.to_string())) | ||
| } |
There was a problem hiding this comment.
While most of this diff is within noise of allocations elsewhere in the system, removing this allocation does show a teeny tiny improvement here:
|
Huh, what are those test failures about? |
|
(For future readers, test failures were integration issues fixed by #1545) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Inspired by pydantic/jiter#166 I had a quick look to see if similar uses could be optimised in core.
Related issue number
N/A
Checklist
pydantic-core(except for expected changes)