Added le and ge bounds to constrained numerics.
#194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 10 10
Lines 1149 1172 +23
Branches 214 218 +4
=====================================
+ Hits 1149 1172 +23 |
|
Probably we want to update the docs as well. |
samuelcolvin
reviewed
Jun 7, 2018
There was a problem hiding this comment.
Otherwise this looks great, just one small change, and also could you update HISTORY.rst.
@Gr1N wrote some of this code so might have some feedback too.
tests/test_types.py
Outdated
| def test_number_gt(): | ||
| class Model(BaseModel): | ||
| a: conint(gt=-1) = 0 | ||
| class TestNumberBounds: |
There was a problem hiding this comment.
I understand where you're coming from, but let's stick with no classes in tests for simplicity.
|
And docs, yes. |
Gr1N
reviewed
Jun 7, 2018
pydantic/types.py
Outdated
| try: | ||
| assert new_cls.gt is None or new_cls.ge is None, ('gt', 'ge') | ||
| assert new_cls.lt is None or new_cls.le is None, ('lt', 'le') | ||
| except AssertionError as exception: |
There was a problem hiding this comment.
except AssertionError as e:
...
raise errors.ConfigError(...) from e
Gr1N
reviewed
Jun 7, 2018
tests/test_types.py
Outdated
| @@ -12,6 +12,7 @@ | |||
| from pydantic import (DSN, UUID1, UUID3, UUID4, UUID5, BaseModel, EmailStr, NameEmail, NegativeFloat, NegativeInt, | |||
| PositiveFloat, PositiveInt, PyObject, StrictStr, ValidationError, condecimal, confloat, conint, | |||
| constr, create_model) | |||
| from pydantic.errors import ConfigError | |||
There was a problem hiding this comment.
from pydantic import ConfigError
Gr1N
reviewed
Jun 7, 2018
pydantic/types.py
Outdated
| @@ -175,19 +175,34 @@ def validate(cls, value, values, **kwarg): | |||
| return make_dsn(**kwargs) | |||
|
|
|||
|
|
|||
| class ConstrainedInt(int): | |||
| class ConstrainedMeta(type): | |||
There was a problem hiding this comment.
Maybe better to change name of class? Something like ConstrainedNumberMeta or just NumberMeta?
|
Addressed all comments, I think. |
samuelcolvin
reviewed
Jun 7, 2018
docs/examples/exotic.py
Outdated
| @@ -16,10 +16,12 @@ class Model(BaseModel): | |||
| strip_str: constr(strip_whitespace=True) | |||
|
|
|||
| big_int: conint(gt=1000, lt=1024) = None | |||
| # inclusive: conint(ge=1000, le=1024) | |||
|
Anything else?
…On Thu, 7 Jun 2018 at 16:30, Samuel Colvin ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/examples/exotic.py
<#194 (comment)>:
> @@ -16,10 +16,12 @@ class Model(BaseModel):
strip_str: constr(strip_whitespace=True)
big_int: conint(gt=1000, lt=1024) = None
+ # inclusive: conint(ge=1000, le=1024)
remove
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#194 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIKZDXr02EHf109uMBlgD5bO08C2xx-ks5t6TkCgaJpZM4UeXV_>
.
|
|
great, thank you very much. |
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion #174.