Add lookahead for ip check in AnyUrl

[sbv-csis]

Change Summary

Added lookahead for the ip regex'es to allow for urls with 4 numbers preceeding the rest of the host

Related issue number

fix #1651

Checklist

• Unit tests for the changes exist
• Tests pass on CI and coverage remains at 100%
• Documentation reflects the changes where applicable
• changes/<pull request or issue id>-<github username>.md file added describing change
  (see changes/README.md for details)

[codecov]

Codecov Report

Merging #2512 (eb21f92) into master (619ff26) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #2512   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines         5109      5109           
  Branches      1050      1050           
=========================================
  Hits          5109      5109           

Impacted Files	Coverage Δ
pydantic/networks.py	100.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 619ff26...eb21f92. Read the comment docs.

[PrettyWood]

Thanks a lot for having a look at this! 🙏
Unfortunately there is a test case that used to pass and now fails. I suggest you add it

def test_ipv4_no_port():
    url = validate_url('ftp://123.45.67.8')
    assert url.scheme == 'ftp'
    assert url.host == '123.45.67.8'
    assert url.host_type == 'ipv4'
    assert url.port is None
    assert url.user is None
    assert url.password is None

[sbv-csis]

Thanks a lot for having a look at this!
Unfortunately there is a test case that used to pass and now fails. I suggest you add it

def test_ipv4_no_port():
    url = validate_url('ftp://123.45.67.8')
    assert url.scheme == 'ftp'
    assert url.host == '123.45.67.8'
    assert url.host_type == 'ipv4'
    assert url.port is None
    assert url.user is None
    assert url.password is None

Thanks for the feedback and good catch!
I've added the test and updated the regex - I've made it to match the one used to end the domain group (minus the \s, I don't think that makes sense)

[PrettyWood]

LGTM!

[sbv-csis]

Should/could I do anything else here with this or are we on track for the next steps?

[GitHK]

Will this PR be merged, if yes is there a way to understand when it will be released?
Thanks.

[samuelcolvin]

this is great, thank you so much.

@GitHK I'm aiming to make a new release over the coming weeks, but as you can see there are a lot of PRs to review. If you're hoping for a new release soon, perhaps you could speed things up by reviewing any on PRs with the "ready for review" badge?