-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type name to ValidationError error message #676
Merged
samuelcolvin
merged 5 commits into
pydantic:master
from
dmontagu:type-in-validation-error
Aug 5, 2019
Merged
Add type name to ValidationError error message #676
samuelcolvin
merged 5 commits into
pydantic:master
from
dmontagu:type-in-validation-error
Aug 5, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
==========================================
- Coverage 100% 99.92% -0.08%
==========================================
Files 15 15
Lines 2671 2672 +1
Branches 529 529
==========================================
- Hits 2671 2670 -1
- Misses 0 2 +2 |
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 15 15
Lines 2722 2727 +5
Branches 538 539 +1
=====================================
+ Hits 2722 2727 +5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM.
dmontagu
commented
Jul 19, 2019
dmontagu
force-pushed
the
type-in-validation-error
branch
from
July 23, 2019 19:03
9ac3b5d
to
2cf7bf4
Compare
dmontagu
force-pushed
the
type-in-validation-error
branch
from
July 25, 2019 07:14
2cf7bf4
to
8135f47
Compare
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Make the string displayed for ValidationError contain the name of the model for easier debugging.
Related issue number
#677
Checklist
Codecov seems to be bugging out -- the "uncovered" lines were setting the value of
compiled
inmain.py
(I've marked the tests+coverage checkbox since I think it should be passing).HISTORY.rst
has been updated#<number>
@<whomever>