Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix handling of UUID values having UUID.version=None #7566

Merged
merged 1 commit into from
Sep 22, 2023
Merged

🐛 Fix handling of UUID values having UUID.version=None #7566

merged 1 commit into from
Sep 22, 2023

Conversation

lig
Copy link
Contributor

@lig lig commented Sep 22, 2023 •
edited
Loading

Change Summary

Fix handling of UUID values having UUID.version=None

Related issue number

Fix #7355

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @Kludex

@lig
Copy link
Contributor Author

lig commented Sep 22, 2023

please review

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 72b6c0f
Status: ✅  Deploy successful!
Preview URL: https://096961a1.pydantic-docs2.pages.dev
Branch Preview URL: https://lig-7355-uuid-with-less-than.pydantic-docs2.pages.dev

View logs

@lig lig added the relnotes-fix Used for bugfixes. label Sep 22, 2023
@lig lig enabled auto-merge (squash) September 22, 2023 13:32
@lig lig merged commit 56df0cf into main Sep 22, 2023
58 of 60 checks passed
@lig lig deleted the lig/7355-uuid-with-less-than-8000-fails-with-nonetype branch September 22, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees

@Kludex Kludex

Labels
ready for review relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UUID with less than 8000 fails with NoneType
2 participants
@lig @Kludex