Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failing for arm64 #394

Open
odidev opened this issue Dec 2, 2021 · 5 comments
Open

Build failing for arm64 #394

odidev opened this issue Dec 2, 2021 · 5 comments
Assignees
Labels

Comments

@odidev
Copy link
Contributor

odidev commented Dec 2, 2021

I have been working on installing and testing bottleneck package for amd64 and arm64 architectures. I am getting the below error on arm64 architecture for the command python setup.py build_ext --inplace

aarch64-linux-gnu-gcc -pthread -E -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/python3.8 -I/usr/include/python3.8 -o _configtest.i _configtest.c 
_configtest.c:1:10: fatal error: emmintrin.h: No such file or directory 

    1 | #include <emmintrin.h> 
      |          ^~~~~~~~~~~~~ 
compilation terminated. 

Further I explored about the issue, got that ARM CPUs do not support this.

Could you please provide your feedback regarding this.

Log for reference: https://github.com/odidev/bottleneck/runs/4380495013?check_suite_focus=true

@odidev
Copy link
Contributor Author

odidev commented Feb 18, 2022

Is there any update for the above issue?

@rdbisme
Copy link
Collaborator

rdbisme commented Feb 18, 2022

Hello @odidev, no updates on this. We've recently been promoted as maintainers (see #388) to give a help to maintain the package. We've published a roadmap there. We'll try to see if fixing this can be taken into account once we have a working CI also for aarch64.

@odidev
Copy link
Contributor Author

odidev commented Mar 14, 2022

@rdbisme Thanks for update.

@blthayer
Copy link

blthayer commented Jun 2, 2022

Hello,

I am also interested in an ARM build for bottleneck. It looks like @odidev was able to get this to succeed:

Is there any plan for official bottleneck support for ARM?

@rdbisme
Copy link
Collaborator

rdbisme commented Jun 9, 2022

Hello @blthayer, I think it's for sure interesting to have support for ARM as soon as it doesn't impact performance on other architectures. Pull requests welcome! :) I'd say to split the contribution as:

  1. Adding missing code needed to allow build on armv7 and aarch64 and Apple Silicon
  2. Ensure that the added code doesn't impact other architectures
  3. Tweaking CI to test, build and release for ARM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants