Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve parser performance when handling special characters #1204

Closed
changhiskhan opened this issue May 7, 2012 · 2 comments
Closed

Improve parser performance when handling special characters #1204

changhiskhan opened this issue May 7, 2012 · 2 comments
Labels
Enhancement IO Data IO issues that don't fit into a more specific label
Milestone
0.10

Comments

@changhiskhan
Copy link
Contributor

thousands separator and comments (#962) processing is slow right now.

at least comments should be preprocessed
@wesm
Copy link
Member

wesm commented Nov 2, 2012

Thousands handling is handled at a low level in the new parser. Have to think about the comments argument and how to do it without slowing down the tokenizer

@wesm
Copy link
Member

wesm commented Nov 28, 2012

Thousands handling is way faster, but the C parser doesn't do comments yet. Should be simple (ish) to add to the tokenizer.

@wesm wesm closed this as completed in 238f522 Nov 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement IO Data IO issues that don't fit into a more specific label
Projects
None yet
Milestone
0.10
Development

No branches or pull requests
2 participants
@wesm @changhiskhan