Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Allow referencing of Excel columns by their Excel column names. #1936

Closed
wants to merge 8 commits into from

Conversation

snth
Copy link
Contributor

@snth snth commented Sep 19, 2012

I find it more convenient to refer to the columns as they are in Excel by their string representations.

The excel2num() function I found on StackOverflow. Does that need to be referenced/acknowledged?

I'm happy to put in some unit tests but couldn't find a natural home for it. Most of the ExcelFile tests sit in test_frame.py but I think something like test_io.py or test_parsers.py would be a better fit.

@wesm
Copy link
Member

wesm commented Sep 20, 2012

All you have to do is push additional commits to the branch (well, your master branch in this case-- see http://pandas.pydata.org/developers.html#working-with-the-code for the future). Would you mind adding a unit test that addresses this new behavior (you can use one of the .xls files that are already used in the test suite)

@snth
Copy link
Contributor Author

snth commented Sep 20, 2012

Thanks Wes. I wanted that feature for myself so I just started hacking at it. I will follow the guidelines in future.

I've made the change I pointed out above and added a unit test for the 'str' behaviour that replicates the existing parse_cols unit tests.

Please review and see if you're happy with it.

@wesm
Copy link
Member

wesm commented Oct 31, 2012

cherry-picked the relevant commits. thanks!

@wesm wesm closed this Oct 31, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants