Use stdlib csv module to write csv #206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool. I was actually made aware of this a while ago but as you can see forgot to fix it ;) I'm sure performance is better, too. |
|
I wouldn't expect a big performance difference, but it may be a bit faster, since I think csv.writer is implemented in C. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while using pandas that data with commas in the fields wasn't getting escaped properly when written to CSV (data in biology often has bits of text as well as numbers). This causes the data to spread out over extra columns. This commit uses the
csvmodule from the standard library to write out CSV 'properly'.I've also added a simple test for this case.