-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: del df[k] with non-unique key #2349
Conversation
I'll check on my machine when I get a chance if there's any perf difference. I also need to figure out why Travis has become totally borked. most likely my fault |
yeah, things are failing on py2 as well now, and I don't think that's a problem on the travis side. |
Oh definitely. I'll fix asap |
Vbenchmarks looked fine on my end so I went ahead and merged this one |
On Python 3 it looks like some issue with NumPy using |
it's in the final stages of resolution, should be fixed once travis upgrade to venv 1.8.4 within a couple days |
Great. looks like venv 1.8.4 was cut today |
This touches some delicate functions to be messing with, so I've split off the
underlying logic into a function in common and added an exhaustive test.
Would welcome review none the less.
Also, I tried to test for nagative perf. There must something
wrong with the test since comparing the commit after just adding a test to the baseline,
shows 50% degredation in a bunch of things. As I said, I don't trust this, ideas?
closes #2347