Periods don't sort correctly

[dhirschfeld]

Unless I'm mistaken I think the following unit-test should pass:

def test_period_sorting():
    periods = [pd.Period('2008-04', 'M'),
               pd.Period('2008-02', 'M'),
               pd.Period('2008-01', 'M'),
               pd.Period('2008-05', 'M'),
               pd.Period('2008-06', 'M'),
               pd.Period('2008-03', 'M'),
               pd.Period('2008-04', 'M'),
               pd.Period('2008-02', 'M'),
               pd.Period('2008-01', 'M'),
               pd.Period('2008-05', 'M'),
               pd.Period('2008-06', 'M'),
               pd.Period('2008-03', 'M'),
               pd.Period('2008-04', 'M'),
               pd.Period('2008-02', 'M'),
               pd.Period('2008-01', 'M'),
               pd.Period('2008-05', 'M'),
               pd.Period('2008-06', 'M'),
               pd.Period('2008-03', 'M')]
    assert sorted([p.to_timestamp() for p in periods]) \
        == [p.to_timestamp() for p in sorted(periods)]
#

[jreback]

can you copy your example to your PR, and then close this? thxs

[dhirschfeld]

AFAIK the "correct" way to do this is to state closes #2781 or fixes #2781 in your commit message in which case GitHub will automatically add a reference to this issue in your PR and will automatically close this issue when your PR gets merged into upstream. The reason this isn't being done is because you're missing the # symbol in front of the issue number.

I think it would be a bit premature to close the issue before PR is merged, but I'm watching the PR & am happy to close once it gets merged.

[dhirschfeld]

This issue is fixed in PR #2987.

[ghost]

I tend to avoid # mentions in commit messages, because rewriting PR branches and pushing
pollutes the issue page with multiple references, so I stopped using it and use GH1234
instead, closing things manually. github support never got back to me on being able to
delete references manually, that was months ago.

[jreback]

yes you are right, just trying to remove the issues from the 0.11 list (and your PR is marked 0.11, but on the PR list not issues)....