Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: deprecate DataFrame.interpolate #3675

Merged
merged 1 commit into from
May 22, 2013
Merged

API: deprecate DataFrame.interpolate #3675

merged 1 commit into from
May 22, 2013

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented May 21, 2013

closes #3582.

@jreback
Copy link
Contributor

jreback commented May 21, 2013

can you also add a deprecation if interpolate is called? (done a slightly different way, but look in core.categorical how Factor was deprecated; and in the warning message point to fillna/replace)

thxs

@jreback
Copy link
Contributor

jreback commented May 21, 2013

great....i'll merge this....pls add a new issue (as a reminder to do this), and i'll tag it

txs

@cpcloud
Copy link
Member Author

cpcloud commented May 21, 2013

shall i add the appropriate issue to v0.11.1.txt and RELEASE.rst?

@cpcloud
Copy link
Member Author

cpcloud commented May 21, 2013

oh wait don't merge yet i had to grsh and now i must rewrite the notes. :|

@jreback
Copy link
Contributor

jreback commented May 21, 2013

yep...rel notes (see how I did for tupleize_cols).....and v0.11.1 announcing that we are deprecating (in the API changes section)

add a more useful warning message

use the correct tense

DOC: rls notes
@jreback
Copy link
Contributor

jreback commented May 21, 2013

perfect this is basically just adding the warning and the v0.11.1, letting everyone know its going to change

@jreback
Copy link
Contributor

jreback commented May 22, 2013

this ready right?

@cpcloud
Copy link
Member Author

cpcloud commented May 22, 2013

yup

jreback added a commit that referenced this pull request May 22, 2013
API: deprecate DataFrame.interpolate
@jreback jreback merged commit 2bd1cf8 into pandas-dev:master May 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surprising behavior of DataFrame.replace
2 participants