ENH/API: implement __nonzero__ for NDFrame #3696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this didn't break any tests? (other than the one that is meant to catch it) |
|
Nope. I changed that test to reflect the api change. |
|
I figured that it would be more difficult to do this but it seems like the object hierarchy is very clean and only getting better :) |
ENH/API: remove __nonzero__ in frames, use NDFrame implementation
|
can u rebase? |
|
done |
jreback
added a commit
that referenced
this pull request
May 30, 2013
ENH/API: implement __nonzero__ for NDFrame
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3691.