Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more momery efficient describe() for DataFrame #425

Closed
wants to merge 1 commit into from

Conversation

joonro
Copy link

@joonro joonro commented Nov 30, 2011

reindex() in describe() in DataFrame was making copy of the data. I changed describe() so it processes one column at a time instead of get all columns with reindex(). It seems to be a better implementation (much less memory usage).

@wesm
Copy link
Member

wesm commented Dec 2, 2011

hi Joon, thanks, cherry-picked this into master. in the future can you make pull requests out of a feature branch? if you try to pull/merge wesm/master now you are going to generate a merge commit which will makes things a bit hairy. you may wish to git reset --hard to a commit before your change, then pull wesm/master

@wesm wesm closed this Dec 2, 2011
@joonro
Copy link
Author

joonro commented Dec 2, 2011

Of course. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants