From 3b0c73e93d1f1b52f45b4918015c66fe5142c294 Mon Sep 17 00:00:00 2001
From: Gabriel Fouasnon <gabriel@fouasnon.com>
Date: Fri, 8 Dec 2023 16:50:15 -0500
Subject: [PATCH] frozen data class

---
 tests/test_a11y.py | 31 +++++++++++++++++++++----------
 1 file changed, 21 insertions(+), 10 deletions(-)

diff --git a/tests/test_a11y.py b/tests/test_a11y.py
index c462e43bf..1d9ab6f5e 100644
--- a/tests/test_a11y.py
+++ b/tests/test_a11y.py
@@ -1,6 +1,7 @@
 """Using Axe-core, scan the Kitchen Sink pages for accessibility violations."""
 
 import time
+from dataclasses import dataclass
 from http.client import HTTPConnection
 from pathlib import Path
 from subprocess import PIPE, Popen
@@ -70,20 +71,30 @@ def url_base():
         process.wait()
 
 
-def fingerprint_violations(accessibility_page_scan_violations):
+@dataclass(frozen=True)
+class AxeViolationFingerprint:
+    """Fingerprint for single Axe violation."""
+
+    id: str
+    help: str
+    helpUrl: str
+    targets: tuple
+
+
+def fingerprint(accessibility_page_scan_violations):
     """Create a fingerprint of the Axe violations array.
 
     https://playwright.dev/docs/accessibility-testing#using-snapshots-to-allow-specific-known-issues
     """
-    return [
-        {
-            "id": violation["id"],
-            "help": violation["help"],
-            "helpUrl": violation["helpUrl"],
-            "targets": [node["target"] for node in violation["nodes"]],
-        }
+    return tuple(
+        AxeViolationFingerprint(
+            violation["id"],
+            violation["help"],
+            violation["helpUrl"],
+            tuple(node["target"] for node in violation["nodes"]),
+        )
         for violation in accessibility_page_scan_violations
-    ]
+    )
 
 
 @pytest.mark.a11y
@@ -171,7 +182,7 @@ def test_axe_core(
     results = page.evaluate("axe.run()" if selector == "" else f"axe.run('{selector}')")
 
     # Check found violations against known violations that we do not plan to fix
-    data_regression.check(fingerprint_violations(results["violations"]))
+    data_regression.check(fingerprint(results["violations"]))
 
 
 def test_version_switcher_highlighting(page: Page, url_base: str) -> None: