From fd3f8c52cda3962d9b83bee255b9662efff91bc5 Mon Sep 17 00:00:00 2001 From: Rambaud Pierrick <12rambau@users.noreply.github.com> Date: Wed, 23 Aug 2023 16:47:27 +0200 Subject: [PATCH] fix: don't display the warning bar if there is an issue (#1420) but don't block the whole javascript page loading --- .../assets/scripts/pydata-sphinx-theme.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js b/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js index 0ad64952b..8b04b09db 100644 --- a/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js +++ b/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js @@ -425,9 +425,10 @@ function showVersionWarningBanner(data) { var preferredEntries = data.filter((entry) => entry.preferred); if (preferredEntries.length !== 1) { const howMany = preferredEntries.length == 0 ? "No" : "Multiple"; - throw new Error( - `[PST] ${howMany} versions marked "preferred" found in versions JSON` + console.log( + `[PST] ${howMany} versions marked "preferred" found in versions JSON, ignoring.` ); + return; } const preferredVersion = preferredEntries[0].version; const preferredURL = preferredEntries[0].url;