Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infinite loop in nox -s docs-live #1256

Closed
drammock opened this issue Mar 21, 2023 · 3 comments · Fixed by #1265
Closed

infinite loop in nox -s docs-live #1256

drammock opened this issue Mar 21, 2023 · 3 comments · Fixed by #1265
Labels
kind: bug Something isn't working

Comments

@drammock
Copy link
Collaborator

on current main, if I do this:

rm -r .nox/
rm -r node_modules/
rm package-lock.json
mamba env create -n pst python
conda activate pst
pip install sphinx-theme-builder[cli]
pip install -e .[dev]

I would expect nox -s docs-live to work, but it does not: it runs to completion and pops open the browser window and then immediately starts rebuilding as if a file had changed. It continues rebuilding indefinitely as soon as the prior (re-)build completes. Even if I were ok with all that needless rebuilding happening in the background, it makes the live site hard to use because it gets a reload signal frequently, and the page reload is slow (reason unknown but presumably related, since it's a local site).

(NB: this was happening before I recreated the dev env / deleted all the node modules and nox envs; I recreated the dev env from scratch just to make sure it wasn't a fluke).

@trallard
Copy link
Collaborator

Adding another observation point - I was experiencing the same issue today after I merged main back onto my working branch.

@drammock
Copy link
Collaborator Author

as @gabalafou noted here this appears to be caused by the language translation files changing. cc @jpmckinney any insight into how to prevent this?

@jpmckinney
Copy link
Contributor

Ignore changes to those files as far as rebuilds go. I’m not familiar with the nox command but if it’s using sphinx-autobuild then there is an option to ignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants