Search and light/dark switch not working in local macOS html build in 0.14.x

[fedepad]

Hi, I have been using this theme! Good job to all, it looks neat.

I have to report that between version 0.13 and the latest 0.14.3 something changed and broke some functionality that comes out of the box.
Precisely, up to 0.13.3 works fine and then starting from 0.14.0 breaks some UI elements that I mention below.

OS: macOS
Build type: local sphinx html build

For example:
in 0.13

• search works fine and can be enabled (the search box)
• light/dark switch works fine

in 0.14.3

• search doesn't work, cannot even open the search box by clicking on it nor type inside of it
• light/dark switch doesn't work; I click on the icon but nothing changes

I haven't explored if there are more problems, but these are the ones that are easy to spot.
I also have not gone much deeper with an analysis to try to figure out which commits break those elements.

Thanks for your work!

[trallard]

Thanks for raising this @fedepad unfortunately I have not been able to reproduce this on my local MacOS machine.

@gabalafou since you have been deep in dev mode can you check whether you can reproduce this on your end?

[fedepad]

@trallard I just found out what was probably the problem.
Basically the json_url for the version switcher was wrong and this somehow was messing up the light/dark switch and the search field.
Giving a correct url for the version switcher seems to have solved the problem; running on 0.14.4.
So the issue can be closed for me, I will let you do it, in case you need to do any bookeeping.

Thanks again!

[drammock]

to me it sounds like the problem with the version switcher was raising an error that prevented the rest of the page's JavaScript from running. Both the light/dark switch and the search need JS in order to work. We've already fixed something similar in #1420 which should have been present in all of the 14.x releases, so maybe your wrong URL was causing it to error out in a different spot.

[trallard]

Since this seems to have been resolved I will go ahead and close this issue. Thanks folks 🙏🏽