Search button/field broken on local development build

[dstansby]

With a local development build of the theme, searching appears to be broken. When I click on the search field nothing happens, where a search box should appear in the middle of the website. Pressing cmd+k does not work either, and instead opens the search bar of my browser.

I'm on current main (fff6837) and built the docs using nox -s docs. Not really sure what other debug info would be useful, but happy to help!

(I found this when trying to debug another search issue, but if I can't get search to work in a vanilla build then I don't have much hope tracking down my other issue 😄 )

[dstansby]

I've managed to bisect this breaking back to b36c6d8 (from #1344)

[drammock]

can you check the browser console? It sounds like some JS is raising an error during page load, thus preventing the search-related JS from ever executing. I see that b36c6d8 included a new throw err line in the JS, so that strengthens my suspicion that the problem may actually be something related to the version switcher.

[dstansby]

When I mouseover the search field in the console I get

Request for font "Noto Sans" blocked at visibility level 2 (requires 3)
[getOffsetParent.js:11:2](webpack://pydata_sphinx_theme/node_modules/@popperjs/core/lib/dom-utils/getOffsetParent.js)

When I try clicking on the search field nothing else comes up.

[drammock]

and if you scroll back in the browser console, there are no errors thrown earlier (during page load) related to the version switcher? Does the version switcher look ok / work normally in the site?

[dstansby]

There's this (sorry, can't work out how to copy/paste the text...) which points to line 352 which is inside the fetchVersionSwitcherJSON function:

[drammock]

That looks like the culprit to me... Ah! OK sorry, I missed that you were using nox -s docs. I can reproduce. Can you try it with nox -s docs-live please? That works for me locally (version switcher works, and Ctrl+k also works).

I'm not saying we shouldn't try to fix this... but maybe with docs-live you can at least get back to the issue you were originally trying to debug

[dstansby]

Yes, docs-live works fine. Would be nice to fix this though so static builds of third party docs have working search without needing to serve them live.