Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next steps: accessibility testing #1919

Closed
1 of 8 tasks
gabalafou opened this issue Jul 3, 2024 · 1 comment
Closed
1 of 8 tasks

Next steps: accessibility testing #1919

gabalafou opened this issue Jul 3, 2024 · 1 comment
Assignees
Labels
tag: accessibility Issues related to accessibility issues or efforts

Comments

@gabalafou
Copy link
Collaborator

gabalafou commented Jul 3, 2024

Copied from comment on now closed issue:


Almost all of the Axe violations for our current set of test pages have been addressed. Our recent upgrade of Accessible-pygments fixed most of the remaining color contrast issues.

There are only two remaining color contrast issues:

  • Notebook cell numbers (output via nbsphinx) do not have enough contrast, neither in light mode nor in dark mode.
  • Xarray has some color contrast issues:
    • Fix some of these with Force light mode for notebook outputs #1812
    • For the others, write some special case style rules to override Xarray's own styles in the short-term,
    • Longer term, file an issue or pull request to fix upstream

The only other issue has to do with ipyleaflet. When that widget fails to load, it displays a SVG icon of a broken document, but that SVG icon does not have alt text. This is also something outside our control and we will need to file an issue or pull request upstream. In the meantime, I will add code to:

  • Ignore the accessibility violation from the ipyleaflet error missing alt text

Future work

  • Strategically add a few more of our docs pages to our set of test pages to scan with Axe-core
  • Work with maintainers of nbsphinx, MyST-NB, ipywidgets, and other tools in the PyData ecosystem to improve their accessibility
@gabalafou gabalafou self-assigned this Jul 3, 2024
@trallard trallard added the tag: accessibility Issues related to accessibility issues or efforts label Jul 3, 2024
@trallard
Copy link
Collaborator

trallard commented Oct 1, 2024

Seems some of these items have been resolved or superseded by other work/decisions, so will close the issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: accessibility Issues related to accessibility issues or efforts
Projects
None yet
Development

No branches or pull requests

3 participants