setting display: block on inline targets breaks things badly

[drammock]

We're using sphinxcontrib-bibtex to handle citations; notice how the left bracket on the reference link is no longer inline, it shows up separated from its number and crashing into the title, and the remainder of the text starts a new paragraph:

I think this problem was introduced with #283 (or possibly #280).

this is how it should look (ignore the different spacing between top navbar and section title, that's just a page scrolling difference):

A proposed fix using javascript instead of CSS (note that the various disjuncts in the conditional may need to be made more general for it to work for all sphinx sites, not just ours):

<!-- this snippet prevents in-text anchors from being hidden under the -->
<!-- navbar when the page scrolls to them (citation/equation backlinks -->
<!-- are worst affected). -->
<script type="text/javascript">
    if ($(".navbar.fixed-top").length > 0) {
        var navHeight = $(".navbar").height();
        var shiftWindow = function() {
                var ourURL = document.URL;
                if ( (ourURL.search(/#[a-z]+\d\d\d\d$/) > 0) ||  // footbib item (bibtex key)
                     (ourURL.search("#id") > 0) ||               // footbib backreference
                     (ourURL.search("#equation") > 0) ) {        // numbered equation
                    scrollBy(0, -navHeight - 12);
                };
            };
        if (location.hash) shiftWindow();
        window.addEventListener("hashchange", shiftWindow);
    };
</script>

[jorisvandenbossche]

Thanks for the report!
Does one of the preview builds in mne-tools/mne-python#8757 exhibit this, so it can be inspected live?

We actually have some footnote examples in the demo docs at https://pydata-sphinx-theme.readthedocs.io/en/latest/demo/demo.html#footnotes, so we should need to figure out what the difference is with the ones generated by sphinxcontrib-bibtex, as it seems to be working in our demo.

[drammock]

Here it is: https://24938-1301584-gh.circle-artifacts.com/0/dev/overview/implementation.html#id1

Sorry, I should have thought to include that to begin with.

[drammock]

actually it's broken on your demo site too: https://pydata-sphinx-theme.readthedocs.io/en/latest/demo/demo.html#id25

[jorisvandenbossche]

Hmm, how did you get to that link?
If I just go to the demo page (without #id25 in the url), it renders fine. And don't directly see where I need to click to get that id25. When clicking the actual reference to go to the footnote, that works fine (although the offset doesn't seem to be working in this case, as it's hidden behind the navbar .. so that's another case that is not yet fixed).

[jorisvandenbossche]

OK, I see, it's the "back" reference from the footnote to where it is referenced. That indeed triggers the issue in our demo docs as well. Thanks for pointing that out!