Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate version switcher JS from the jinja templates #522

Closed
damianavila opened this issue Dec 3, 2021 · 5 comments
Closed

Migrate version switcher JS from the jinja templates #522

damianavila opened this issue Dec 3, 2021 · 5 comments
Assignees

Comments

@damianavila
Copy link
Collaborator

On the version switcher PR that was recently merged I have requested some changes (
#436 (comment)) that we agreed it would be material for a follow-up PR.
This is an issue to capture that idea and link the implementation when that one is written.

@pradyunsg
Copy link
Contributor

FWIW, this interfaces closely with pradyunsg/sphinx-basic-ng#12 (where I'm trying to figure out a way to have agnostic-to-hosting version and language switchers).

@damianavila
Copy link
Collaborator Author

Thanks for the reference, @pradyunsg.
I will take at it soon!!

@damianavila
Copy link
Collaborator Author

Related (since it involves moving JS from the templates into some other place): #28

@12rambau
Copy link
Collaborator

Isn't it the case ?

function checkPageExistsAndRedirect(event) {

@drammock
Copy link
Collaborator

Yes, this is done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants