Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_store and dump_to_store #3638

Open
keewis opened this issue Dec 17, 2019 · 1 comment
Open

load_store and dump_to_store #3638

keewis opened this issue Dec 17, 2019 · 1 comment

Comments

@keewis
Copy link
Collaborator

keewis commented Dec 17, 2019

Continuing from #3602, load_store and dump_to_store look like they are old and unmaintained functions:

  • load_store is referenced once in api.rst (I assume the reference to from_store was to load_store), but never tested, used or mentioned anywhere else
  • dump_to_store is tested (and probably used), but never mentioned except from the section on backends

what should we do with these? Are they obsolete and should be removed or just unmaintained (then we should properly document and test them).

@shoyer
Copy link
Member

shoyer commented Nov 8, 2021

I would put these in the "obsolete and should be removed" category. These APIs need to be rationalized with the new modular backends API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants