Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Nightly upstream-dev CI failed ⚠️ #4717

Closed
github-actions bot opened this issue Dec 20, 2020 · 3 comments · Fixed by #4757
Closed

⚠️ Nightly upstream-dev CI failed ⚠️ #4717

github-actions bot opened this issue Dec 20, 2020 · 3 comments · Fixed by #4757
Labels
CI Continuous Integration tools

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2020

Workflow Run URL

Python 3.8 Test Summary Info
FAILED xarray/tests/test_dask.py::TestToDaskDataFrame::test_to_dask_dataframe
FAILED xarray/tests/test_dask.py::TestToDaskDataFrame::test_to_dask_dataframe_2D
FAILED xarray/tests/test_dask.py::TestToDaskDataFrame::test_to_dask_dataframe_coordinates
@github-actions github-actions bot added the CI Continuous Integration tools label Dec 20, 2020
@keewis
Copy link
Collaborator

keewis commented Dec 20, 2020

this fails because pandas changed the way they treat dask arrays passed to their constructor: we now get a series of object dtype filled with 0d dask arrays.

We can work around that by computing x before passing it to pandas.DataFrame in the to_dask_dataframe tests:

expected_pd = pd.DataFrame({"a": x.compute(), "b": y}, index=pd.Index(t, name="t"))

or by assigning the initial numpy array to x and converting it to a dask array immediately before passing it to the xr.Dataset constructor:

x = np.random.randn(10)
# ...
ds = xr.Dataset({"a": ("t", da.from_array(x, chunks=4)), "b": ("t", y), "t": ("t", t)})

(and something similar for the other two failing tests)

But maybe we should just ask the pandas devs whether that was intentional?

@dcherian
Copy link
Contributor

But maybe we should just ask the pandas devs whether that was intentional?

cc @TomAugspurger

@TomAugspurger
Copy link
Contributor

I'm not sure offhand. Maybe best to post an issue on the pandas tracker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants