datatree ops.py migration cleanup #8963
Labels
topic-DataTree
Related to the implementation of a DataTree class
Comments
flamingbear
added
the
needs triage
TomNicholas
added
topic-DataTree
shoyer
added a commit
to shoyer/xarray
that referenced
this issue
Oct 7, 2024
They now allow for dimensions that are missing on particular nodes, and use Xarray's standard generate_aggregations machinery, like aggregations for DataArray and Dataset. Fixes pydata#8949, pydata#8963
shoyer
added a commit
that referenced
this issue
Oct 13, 2024
* Reimplement DataTree aggregations They now allow for dimensions that are missing on particular nodes, and use Xarray's standard generate_aggregations machinery, like aggregations for DataArray and Dataset. Fixes #8949, #8963 * add API docs on DataTree aggregations * remove incorrectly added sel methods * fix docstring reprs * mypy fix * fix self import * remove unimplemented agg methods * replace dim_arg_to_dims_set with parse_dims * add parse_dims_as_set * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix mypy errors * change tests to match slightly different error now thrown --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: TomNicholas <tom@cworthy.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is your issue?
During the 3/26/2024 design discussion meeting (#8747), we discussed the monkey patching of methods that was required to wrap datatree nodes with the desired Xarray API function. This was a primarily done as a necessity due to the datatree code not living in the xarray repository. The better implementation could be to add the wrapping to xarray's
generate_aggregations.pymodule. The ultimate decision made by Stephan and Tom was to add this as a future issue (this one) and migrate the file as is for now.The text was updated successfully, but these errors were encountered: