Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0 Release #491

Closed
6 tasks done
scaramallion opened this issue May 30, 2020 · 4 comments
Closed
6 tasks done

v2.0.0 Release #491

scaramallion opened this issue May 30, 2020 · 4 comments
Milestone

Comments

@scaramallion
Copy link
Member

scaramallion commented May 30, 2020

Housekeeping

  • Drop support for Python 3.5 and add it for Python 3.9
  • Switch to using f-strings
  • Add type hints

Core

  • Switch fro bytes to str for PDU and primitive parameters
  • Set Windows timer resolution to match the DUL loop resolution while Association is active

API

  • Allow passing a file path to send_c_store()
@scaramallion scaramallion added this to the v2.0.0 milestone May 30, 2020
@scaramallion scaramallion pinned this issue May 30, 2020
@Betalos
Copy link

Betalos commented Jun 12, 2020

@scaramallion, for the threading/networking i would suggest someting that could be interfaced with something like gunicorn (tornado for example).
with gunicorn we benifit from process spawn and with nginx balancing the stream (this just an idea)

@scaramallion
Copy link
Member Author

Yeah, gunicorn is one of the things I've been thinking about, as well as twisted, and maybe trio...

@chsasank
Copy link
Contributor

chsasank commented Aug 3, 2020

Hi, we are looking to integrate pynetdicom with twisted. We can contribute this back to pynetdicom if there's interest. It'd also help us a lot if you can help us with the design.

We chose twisted because tutorials and documentation for creating non-http protocols like smtp, ssh is excellent.

@scaramallion
Copy link
Member Author

scaramallion commented Dec 27, 2021

Release checklist

  • update release notes by going through commit history (if required)
  • update the version in pynetdicom/_version.py to release
  • create a new GitHub release
  • create a new branch major.minor.X
  • publish on PyPi
    • remove build dir (if present)
    • create universal wheel and source: python setup.py sdist bdist_wheel
    • upload to testing.pypi.org: twine upload -r testpypi dist/*
      • create a new virtualenv and install: pip install -i https://test.pypi.org/simple/ pynetdicom
      • run unit tests: pip install pytest; python -c "import pytest; pytest.main(['--pyargs', 'pynetdicom.tests'])"
      • test release is good
    • upload to pypi.org: twine upload dist/*
      • create a new virtualenv and install: pip install pynetdicom pytest
      • run unit tests: python -c "import pytest; pytest.main(['--pyargs', 'pynetdicom.tests'])"
      • release is good
  • update documentation version on GitHub Pages
git checkout gh-pages
git pull upstream gh-pages
cp -r dev major.minor  # copy dev to new directory for version being released
unlink stable
ln -s major.minor stable  # link stable to new directory
git add major.minor  # add newly copied directory to git
git commit -am 'DOC new release major.minor [skip-ci]'
git push upstream gh-pages  # commits directly, no PR needed
  • update conda build

Post-release checklist

  • update the version in pynetdicom/_version.py in master to next development version (major.minor.0.dev0)
  • create new release notes in pynetdicom/docs/changelog/major.minor.patch.rst
  • Include new release notes in pynetdicom/docs/changelog/index.rst
  • remove functions/classes/objects scheduled for deprecation

@scaramallion scaramallion unpinned this issue Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants