Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pynetdicom StoreSCP - Performance #684

Closed
gswitch opened this issue Sep 21, 2021 · 1 comment
Closed

Pynetdicom StoreSCP - Performance #684

gswitch opened this issue Sep 21, 2021 · 1 comment
Labels

Comments

@gswitch
Copy link

gswitch commented Sep 21, 2021

Hi Scaramallion,
Alright?

I don't know if this is the channel for doubts, forgive me if I'm wrong.

I've been working with Orthanc for about 4 years, but now I met Pynetdicom and I was very happy with its documentation, examples and everything it offers, congratulations on the work!

My goal is to migrate to Python, using pynetdicom and pydicom, so as a challenge I created mystorescp.py with example code and everything worked, but to my surprise, when receiving larger files (Mammogram or RX) it is very slow, and it can be to 1 minute to save the received .dcm file.

So to compare, I used dcmtk's storescp and then I submitted the same study and it gets it instantly.

All tests were done "localhost".

Am I missing something?
Is this performance on pynetdicom normal?
Any help would be most welcome.

This is mystorecp.py:

This is mystorecp.py:
https://pydicom.github.io/pynetdicom/stable/examples/storage.html

@gswitch
Copy link
Author

gswitch commented Sep 21, 2021

After researching a lot, I got this PR(#651), comparing with my version (dul.py) they are different, I imagine that this PR should be released in future versions, am I right?

Just for testing purposes, I made the same PR changes and it really solves the performance problem.

Special thanks to Matthew for helping with this issue.

I did the installation like this:
pip install pynetdicom

Why do I get a version without this important improvement?
Are there any other more active channels? How a Forum?

Thank you all!
Marcelo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants