Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is prompt changing being removed? #268

Closed
tadeoos opened this issue Jun 19, 2018 · 5 comments · Fixed by #447
Closed

Why is prompt changing being removed? #268

tadeoos opened this issue Jun 19, 2018 · 5 comments · Fixed by #447

Comments

@tadeoos
Copy link

tadeoos commented Jun 19, 2018

Hey,

according to current output:

pyenv-virtualenv: prompt changing will be removed from future release. configure `export PYENV_VIRTUALENV_DISABLE_PROMPT=1' to simulate the behavior.

Can I ask how you came to this decision? I really like this feature

@PaulRBerg
Copy link

You might want to take a look here: #135

@pllim
Copy link

pllim commented Jul 2, 2020

Had the same question. Went with #135 (comment) as my workaround.

@native-api
Copy link
Member

@yyuu , since it was you who added the warning, could you comment?

My guess is that it's because Virtualenv themselves were going to do that.
...and IIRC already did it, so maybe we can proceed with the removal?

Would be nice to learn their rationale, too, of course...

@native-api
Copy link
Member

Looking at https://github.com/pypa/virtualenv/blob/main/src/virtualenv/activation/bash/activate.sh , there's no deprecation, not to mention, removal of the prompt changing in sight.

Lacking any response from @yyuu, my guess is:

Pyenv-virtualenv makes virtualenvs behave like regular installations. The prompt changing removal was intended to erase the difference even further.

@native-api
Copy link
Member

Pyenv-virtualenv makes virtualenvs behave like regular installations. The prompt changing removal was intended to erase the difference even further.

In which case, we can as well go the other way and add printing of the active installation(s) to the prompt in the base Pyenv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants