Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No module named 'packaging' #6

Closed
efojs opened this issue Jun 3, 2021 · 4 comments
Closed

No module named 'packaging' #6

efojs opened this issue Jun 3, 2021 · 4 comments

Comments

@efojs
Copy link

efojs commented Jun 3, 2021

Just installed and run runserver

Get:

$ python manage.py runserver
Watching for file changes with StatReloader
Exception in thread django-main-thread:
Traceback (most recent call last):
  File "/Users/USERNAME/.pyenv/versions/3.8.6/lib/python3.8/threading.py", line 932, in _bootstrap_inner
    self.run()
...
File "/Users/USERNAME/.local/share/virtualenvs/project-G1DqfJzJ/lib/python3.8/site-packages/magiclink/__init__.py", line 2, in <module>
    from packaging import version
ModuleNotFoundError: No module named 'packaging'

What am I doing wrong?
Django: 3.2.4

@efojs
Copy link
Author

efojs commented Jun 3, 2021

Found similar issue: PayneLab/cptac#3
Installing packaging manually fixed it

But do I need it though? Seems like it's required for writing reusable apps
Looks like it should not be a dependency, should it?

@pyepye
Copy link
Owner

pyepye commented Jun 6, 2021

Hi @efojs

Yep looks like this is a break in the current build. packaging used to be automatically installed via Django but no longer is a dependency.
I'm fixing now to not require it.

The issue is only in the latest release. If you want to install version 1.0.1 instead while I create the fix you won't have the dependency issue.

Sorry about that
Matt

@pyepye
Copy link
Owner

pyepye commented Jun 6, 2021

Hi @efojs

Version 1.0.3 has been released. It's also been released to PyPi but can take a while to propagate so pip install might install 1.0.2 for another few minutes.

I decided it keep the packaging dependency so ensure dlevel versions etc were handled properly, I've just made sure it's actually added as a dependency in pyproject.toml.

I'm still not sure why tox didn't catch this mind you, I must of had some old version that met the dependency hanging around.

Again sorry for the issue.

Matt

@efojs
Copy link
Author

efojs commented Jun 6, 2021

Just reinstalled — 1.0.3 — all work well
Thank you for a quick fix!

@efojs efojs closed this as completed Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants